Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal-browser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e54c8bbf2200
Choose a base ref
...
head repository: opal/opal-browser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1652ead3c877
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 28, 2014

  1. Copy the full SHA
    5c1d44b View commit details
  2. Copy the full SHA
    1652ead View commit details
Showing with 6 additions and 3 deletions.
  1. +1 −1 spec/history_spec.rb
  2. +5 −2 spec/runner.rb
2 changes: 1 addition & 1 deletion spec/history_spec.rb
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@
$window.history.state.should eq(23)

$window.on 'pop:state' do |e|
run_async {
async {
true.should eq(true)
}

7 changes: 5 additions & 2 deletions spec/runner.rb
Original file line number Diff line number Diff line change
@@ -34,8 +34,7 @@
# wait until there's a spot in the parallel jobs
begin
loop do
response = RestClient.get(plan)
state = JSON.parse(response.to_str)
state = JSON.parse(RestClient.get(plan).to_str)

if state["parallel_sessions_running"] < state["parallel_sessions_max_allowed"]
break
@@ -58,6 +57,10 @@

# the title is a good way to know if anything went wrong while fetching the
# page
Selenium::WebDriver::Wait.new(timeout: 30, interval: 5).until {
not browser.title.strip.empty?
}

unless browser.title =~ /Opal Browser/
puts "\rThe page failed loading."
exit 1