Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: fd20db77b26a
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 83fb71b5dc9b
Choose a head ref
  • 5 commits
  • 25 files changed
  • 1 contributor

Commits on Aug 16, 2012

  1. Store bugnote URL replacement string in a static variable

    The purpose is to make code more readable.
    
    Follow up on fix for issue #14447.
    dregad committed Aug 16, 2012
    Copy the full SHA
    19b2865 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2012

  1. Upgrade PHPMailer from 5.1 to 5.2.1

    Version 5.2.1 (January 16, 2012)
    * Closed several bugs
    * Performance improvements
    * MsgHTML() now returns the message as required.
    * New method: GetSentMIMEMessage() (returns full copy of sent message)
    
    Version 5.2 (July 19, 2011)
    * protected MIME body and header
    * better DKIM DNS Resource Record support
    * better aly handling
    * htmlfilter class added to extras
    * moved to Apache Extras
    
    Fixes #12562
    dregad committed Aug 17, 2012
    Copy the full SHA
    8c81d4c View commit details
    Browse the repository at this point in the history
  2. Fix #14630: Improved logging for emails

    Prior to this, several e-mail related events were not reported at all,
    making troubleshooting of issues difficult. The following cases are now
    logged:
    
     * sending of queued messages (email_send_all)
     * errors thrown by PHPMailer
     * reminder emails (email_bug_reminder) - fixes #9368
     * deletion of records from the email queue
    
    In addition, admin/email_queue.php was modified to print a formatted
    date instead of a numeric timestamp.
    dregad committed Aug 17, 2012
    Copy the full SHA
    4ff0a95 View commit details
    Browse the repository at this point in the history
  3. Fix #14631: Consistent email validation

    PHPMailer uses filter_var() to check for an e-mail validity; this
    function treats single-domain e-mail addresses (e.g. user@localhost) as
    invalid. However, Mantis API function email_is_valid() relies on a
    custom regex to validate e-mails, which does accept such addresses. As a
    consequence, we accept addresses to which we are unable to send
    messages.
    
    To avoid this problem, we now rely on PHPMailer::ValidateAddress()
    method to ensure that any email we store can be sent PHPMailer.
    dregad committed Aug 17, 2012
    Copy the full SHA
    6987b4a View commit details
    Browse the repository at this point in the history
  4. Do not skip e-mail validation if $g_login_method != LDAP

    Prior to this, function email_is_valid() always returned true when
    $g_use_ldap_email = ON, even if $g_login_method != LDAP.
    
    Even though this is not an usual case (when not using LDAP, the other
    LDAP-related configuration options should be left to their default
    values), this causes the actual validation to be skipped which could
    lead to email sending errors.
    
    Fixes #14632
    dregad committed Aug 17, 2012
    Copy the full SHA
    83fb71b View commit details
    Browse the repository at this point in the history