Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: a880882dc626
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 9767f18eb9dc
Choose a head ref
  • 7 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 8, 2012

  1. stream: Call read(0) on 'readable' emission 

    This is so that, in the case where the user does not call read()
to consume all the bytes and get below the low water mark, we can
still check and try to call _read if appropriate.

This is especially important for hitting the EOF so that we know
to tear down TCP sockets.
    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    07b023b View commit details
    Browse the repository at this point in the history

  2. stream: Set the 'finishing' state for Writable 

    Otherwise, it's impossible to know if you're in the middle of a
'finish' event, since the 'finished' state flag isn't set until
after the event is emitted
    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    59aef08 View commit details
    Browse the repository at this point in the history

  3. child_process: Remove stream.pause/resume calls 

    Unnecessary in streams2
    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    96d0b6d View commit details
    Browse the repository at this point in the history

  4. http: Temporary workaround: Put socket in streams1 mode 

    When it's time to refactor http to streams2, we can remove this.
    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    4e06bd9 View commit details
    Browse the repository at this point in the history

  5. net: More wip, debugging, and streams2 stuff

    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    91e305b View commit details
    Browse the repository at this point in the history

  6. test: Better output in test/simple/test-child-process-fork-net2

    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    ca917e6 View commit details
    Browse the repository at this point in the history

  7. test: Trigger old-mode in tests, and more output

    @isaacs
    isaacs committed Nov 8, 2012
    Copy the full SHA
    9767f18 View commit details
    Browse the repository at this point in the history