SOAP API: add failing test for retrieving issue text in non-latin cha…

…rsets Affects #14157: Array to string conversion error on soap request with PHP 5.4
mantisbt · Nov 14, 2012 · fbbf1d2 · fbbf1d2
1 parent eac6b08
commit fbbf1d2
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
@@ -80,7 +80,7 @@ function mc_issue_get( $p_username, $p_password, $p_issue_id ) {
 	$t_issue_data['status'] = mci_enum_get_array_by_id( $t_bug->status, 'status', $t_lang );
 
 	$t_issue_data['reporter'] = mci_account_get_array_by_id( $t_bug->reporter_id );
-	$t_issue_data['summary'] = $t_bug->summary;
+	$t_issue_data['summary'] = mci_sanitize_xml_string($t_bug->summary);
 	$t_issue_data['version'] = mci_null_if_empty( $t_bug->version );
 	$t_issue_data['build'] = mci_null_if_empty( $t_bug->build );
 	$t_issue_data['profile_id'] = mci_null_if_empty( $t_bug->profile_id );

diff --git a/tests/soap/IssueAddTest.php b/tests/soap/IssueAddTest.php
@@ -543,4 +543,31 @@ public function testCreateIssueWithFieldsByName() {
 		$this->assertEquals( $issueToAdd['resolution']['name'], $issue->resolution->name);
 		$this->assertEquals( $issueToAdd['status']['name'], $issue->status->name);
 	}
+
+	/**
+	 * A test cases that tests the creation of issues with non-latin text, to validate that
+	 * it is not stripped.
+	 */
+	public function testCreateIssueWithNonLatinText() {
+		$issueToAdd = $this->getIssueToAdd( 'IssueAddTest.testCreateIssueWithNonLatinText' );
+
+		$issueToAdd['summary'] = "Здравствуйте!"; // Russian, hello
+		$issueToAdd['description'] = "你好";// Mandarin Chinese, hello
+
+		$issueId = $this->client->mc_issue_add(
+				$this->userName,
+				$this->password,
+				$issueToAdd);
+
+		$this->deleteAfterRun( $issueId );
+
+		$issue = $this->client->mc_issue_get(
+				$this->userName,
+				$this->password,
+				$issueId);
+
+		// explicitly specified fields
+		$this->assertEquals( $issueToAdd['summary'], $issue->summary , 'summary is not correct');
+		$this->assertEquals( $issueToAdd['description'], $issue->description , 'description is not correct');
+	}
 }