Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: f232a7780de6
Choose a base ref
...
head repository: jruby/jruby
compare: 4a0eed602abb
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 31, 2014

  1. Deprecate overloaded setProfile, prefer setProfilingMode

    The ScriptingContainer class contains two methods named `setProfile`,
    which differ only by their single argument type and do very different
    things from one another.  One of the two signatures accepts
    an argument of type `ProfilingMode`, which, in other places in the
    code, is exposed via more explicitly named accessor methods such as
    `getProfilingMode` and `setProfilingMode`.  I'm wondering if maybe
    the method in `ScriptingContainer` was simply accidentally mis-named.
    
    This commit deprecates the `setProfile(ProfilingMode)` method, and
    introduces a replacement method `setProfilingMode(ProfilingMode)`,
    which is more consistent with the rest of the code.
    Chris Price committed Aug 31, 2014
    Copy the full SHA
    05655cc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2014

  1. Merge pull request #1934 from cprice404/maint/jruby-1_7/sc-set-profil…

    …ing-mode
    
    Deprecate overloaded `setProfile`, prefer `setProfilingMode`
    headius committed Nov 2, 2014
    Copy the full SHA
    4a0eed6 View commit details
    Browse the repository at this point in the history