Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: f5f9e8da7167
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 02374d0c178b
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 12, 2013

  1. stream: Empty strings/buffers do not signal EOF any longer

    @isaacs
    isaacs committed Feb 12, 2013
    2
    Copy the full SHA
    6bd4501 View commit details
    Browse the repository at this point in the history

  2. stream: read(0) should not always trigger _read(n,cb) 

    This is causing the CryptoStreams to get into an awful state when
there is a tight loop calling connection.write(chunk) waiting for
a false return.

Because CryptoStreams use read(0) to cycle data, this was causing
the encrypted side to pull way too much data in from the cleartext
side, since the read(0) would make it always call _read.

The unfortunate side effect, fixed in the next patch, is that
CryptoStreams don't automatically cycle when the Socket drains.
    @isaacs
    isaacs committed Feb 12, 2013
    Copy the full SHA
    1762dd7 View commit details
    Browse the repository at this point in the history

  3. tls: Cycle data when underlying socket drains

    @isaacs
    isaacs committed Feb 12, 2013
    Copy the full SHA
    02374d0 View commit details
    Browse the repository at this point in the history