Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 17858aeea2ac
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 7c46e2872d08
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 1, 2012

  1. Fix whitespace

    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    606ceec View commit details
    Browse the repository at this point in the history

  2. Improve access level check to reopen issues

    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    85c132d View commit details
    Browse the repository at this point in the history

  3. Manage config workflow page does not reflect actual config 

    The code did not properly reflect the configuration state when building
the Access Levels form, if the minimum access level was defined using
update_bug_status_threshold and set_status_threshold wass empty, showing
'viewer' for each status except 'new'.

Consequently, saving the page without changes would cause the config to
be saved with all access levels as 'viewer'.

Fixes #14496
    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    a414438 View commit details
    Browse the repository at this point in the history

  4. Simplify and improve code in manage_config_workflow_page.php 

    - Avoid code duplication with a function set_color_override to determine
  override of cells bgcolors attribute
- Use a single loop over the status enum in access_row()
- Removed unnecessary assignments and useless code
    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    2d41753 View commit details
    Browse the repository at this point in the history

  5. Workflow config: delete override if identical to parent 

    The code in manage_config_workflow_set.php now deletes the config
override for the current project if the new settings are identical to
the parent's (ALL_PROJECTS level if project, or file-level if all
projects).

Follow-up fix for issue #14496
    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    c96ca21 View commit details
    Browse the repository at this point in the history

  6. Define default $g_set_status_threshold for NEW to REPORTER 

    This prevents incorrect highlighting of NEW status as an override in the
Access Levels section of manage_config_workflow_page.php, when
$g_bug_submit_status is different from default.

Fixes #14496 (see atrol's bugnote ~33192 and my follow up in ~33325)
    @dregad
    dregad committed Dec 1, 2012
    Copy the full SHA
    7c46e28 View commit details
    Browse the repository at this point in the history