New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization refactoring #263
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename FedoraPolicyEnforcementPoint interface to FedoraAuthorizationDelegate. Instead of passing principals to PEP/authorization delegates, pass the session instance. User and group principals added as session attributes. ServletContainerAuthenticationProvider adds the servlet request as a session attribute (so authorization classes can access request IP address, etc). Changed FedoraUserSecurityContext constructor to take a Principal instance rather than ServletCredentials. Added additional documentation for PEP/authz delegate and other methods.
} | ||
|
||
private void addUserPrincipals(final HttpServletRequest request, | ||
private void addPrincipals(final Credentials credentials, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems cleaner to change #addPrincipals(credentials, principals) to:
private Set collectPrincipals(final Credentials credentials) {...}
…er than adding to one taken as a parameter.
…FAD as AuthorizationDelegate, so we have AbstractRolesAuthorizationDelegate and BasicRolesAuthorizationDelegate.
… (no functional changes)
Resolved with: 3bf9967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://www.pivotaltracker.com/story/show/66946122
Rename FedoraPolicyEnforcementPoint interface to FedoraAuthorizationDelegate.
Instead of passing principals to PEP/authorization delegates, pass the session instance.
User and group principals added as session attributes.
ServletContainerAuthenticationProvider adds the servlet request as a session attribute (so authorization classes can access request IP address, etc).
Changed FedoraUserSecurityContext constructor to take a Principal instance rather than ServletCredentials.
Added additional documentation for PEP/authz delegate and other methods.