This repository has been archived by the owner on Sep 30, 2018. It is now read-only.
Fix loading of nested attributes (Hashes) in REST adapter #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adambeynon 👍 This PR is ready, but not sure what is happening with the CI. |
…_from_nested_json
|
@adambeynon Any update on this ? I have updated the PR and the CI seems ok now. |
…_from_nested_json
Conflicts: opal/vienna/persistence.rb
…_from_nested_json Conflicts: opal/vienna/model.rb
…_from_nested_json
|
@adambeynon Any thoughts on this ? |
|
I'm going to close all PRs before archiving the project, due to lack of maintainers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes loading of hashes from JSON. The previous way caused key-value attributes to be loaded as JS
Objectinto opal, instead ofHash.Also
Model#from_formwas updated to normalise hash keys and values:Another thing this PR fixes is
Persistence#did_destroy, which weren't removing items from the RecordArray.