-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load path with jars not working anymore with 1.7.16 #2017
Comments
Ping @ratnikov. |
this actual means that package goal of the gem-maven-plugin only works with jruby version 1.7.12 and older. |
sigh Stupid gmail considering github updates as "Forum" >.< I'll take a look at it on Monday. We definitely need to keep beefing out test suite to cover all these corner cases. |
it look very much that there are still other problems around path strings which are actually jar:file: URI like jruby/jruby-openssl#11 another case where I got problems with this was dd52792 |
@mkristian is it a good idea to hack around tests instead of 'em failing (and fixing the underlying issues) ? |
@kares I see if I can get failing tests on travis pass the "gem install" problem of jruby-openssl |
@kares I tried to configure the gem-maven-plugin not to use the latest 1.7.17-snapshot for installing the gems, but it is not possible since the plugin inherits the maven-project classloader (class-realm in maven speak) and here I need the latest jruby snapshot since this is one which gets tested. but probably I did not understood your question. anyway the test are still failing - well not the tests but the setup of those tests. regarding dd52792 yes that is a hack and should not reach the actual branch. but the problem is that the same path can have at least 3 different representations which are all treated OK. but in that test assumes there is only ONE representation. so the question is who they are represented internally and how they are detected when they come in as strings, like so I can not fix the underlying issue since any fix will break things here or there. maybe someone just decides what is wanted. |
for the record - I missed to add my test.rb script:
|
…H entries this was a regression introduced with jruby-1.7.13 - fixes #2017 Sponsored by Lookout Inc.
…H entries this was a regression introduced with jruby-1.7.13 - fixes #2017 Sponsored by Lookout Inc.
…H entries this was a regression introduced with jruby-1.7.13 - fixes jruby#2017 Sponsored by Lookout Inc.
LOAD_PATH entries with
jar:file:./my.jar!
do work but entries withjar:file:./my.jar!/
do not work any more with jruby-1.7.16 or jruby-1.7.15 (or jruby-1.7.14).create a jar with two ruby scripts:
echo "puts 'hello'" > hello1.rb; cp hello1.rb hello2.rb; jar -cf my.jar hello*.rb; rm hello*.rb
execute it with jruby 1.7.13
and with jruby-1.7.16
The text was updated successfully, but these errors were encountered: