Skip to content

Commit b042757

Browse files
author
Sebastien Bourdeauducq
committedMar 10, 2013
Fix Register name conflict between Pytholite and Bank
1 parent f93695f commit b042757

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed
 

‎migen/bank/description.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
from migen.fhdl.structure import *
44
from migen.fhdl.specials import Memory
55

6-
class Register(HUID):
6+
class _Register(HUID):
77
pass
88

9-
class RegisterRaw(Register):
9+
class RegisterRaw(_Register):
1010
def __init__(self, name, size=1):
11-
Register.__init__(self)
11+
_Register.__init__(self)
1212
self.name = name
1313
self.size = size
1414
self.re = Signal()
@@ -34,9 +34,9 @@ def __init__(self, name, size=1, access_bus=READ_WRITE, access_dev=READ_ONLY, re
3434
self.w = Signal(self.size)
3535
self.we = Signal()
3636

37-
class RegisterFields(Register):
37+
class RegisterFields(_Register):
3838
def __init__(self, name, fields):
39-
Register.__init__(self)
39+
_Register.__init__(self)
4040
self.name = name
4141
self.fields = fields
4242

@@ -74,7 +74,7 @@ def get_memories(self):
7474
def get_registers(self):
7575
r = []
7676
for k, v in self.__dict__.items():
77-
if isinstance(v, Register):
77+
if isinstance(v, _Register):
7878
r.append(v)
7979
elif hasattr(v, "get_registers") and callable(v.get_registers):
8080
r += regprefix(k + "_", v.get_registers())

‎migen/bank/eventmanager.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@
33
from migen.bank.description import *
44
from migen.genlib.misc import optree
55

6-
class EventSource(HUID):
6+
class _EventSource(HUID):
77
def __init__(self):
88
HUID.__init__(self)
99
self.trigger = Signal()
1010
self.pending = Signal()
1111

12-
class EventSourcePulse(EventSource):
12+
class EventSourcePulse(_EventSource):
1313
pass
1414

15-
class EventSourceLevel(EventSource):
15+
class EventSourceLevel(_EventSource):
1616
pass
1717

1818
class EventManager(Module, AutoReg):
1919
def __init__(self):
2020
self.irq = Signal()
2121

2222
def do_finalize(self):
23-
sources_u = [v for v in self.__dict__.values() if isinstance(v, EventSource)]
23+
sources_u = [v for v in self.__dict__.values() if isinstance(v, _EventSource)]
2424
sources = sorted(sources_u, key=lambda x: x.huid)
2525
n = len(sources)
2626
self.status = RegisterRaw("status", n)
@@ -60,6 +60,6 @@ def do_finalize(self):
6060
self.comb += self.irq.eq(optree("|", irqs))
6161

6262
def __setattr__(self, name, value):
63-
if isinstance(value, EventSource) and self.finalized:
63+
if isinstance(value, _EventSource) and self.finalized:
6464
raise FinalizeError
6565
object.__setattr__(self, name, value)

0 commit comments

Comments
 (0)
Please sign in to comment.