fixed rendering bug in Mojo::URL

mojolicious · May 14, 2013 · 485fa33 · 485fa33
1 parent 44d23d9
commit 485fa33
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -51,7 +51,7 @@
   - Improved documentation.
   - Improved tests.
   - Fixed Perl 5.17.11+ compatibility.
-  - Fixed a few authority bugs in Mojo::URL.
+  - Fixed a few authority and rendering bugs in Mojo::URL.
   - Fixed layout bugs in Mojolicious::Renderer.
   - Fixed support for HEAD request method in Mojo::Server::CGI and
     Mojo::Server::PSGI.

diff --git a/lib/Mojo/URL.pm b/lib/Mojo/URL.pm
@@ -209,7 +209,7 @@ sub to_string {
   if (length(my $query = $self->query->to_string)) { $url .= "?$query" }
 
   # Fragment
-  return $url unless my $fragment = $self->fragment;
+  return $url unless defined(my $fragment = $self->fragment);
   return $url . '#' . url_escape $fragment, '^A-Za-z0-9\-._~!$&\'()*+,;=%:@/?';
 }
 

diff --git a/t/mojo/url.t b/t/mojo/url.t
@@ -97,6 +97,16 @@ is $url->query, '_monkeybiz%3B=&_monkey=&23=', 'right query';
 is $url->fragment, '23', 'right fragment';
 is "$url", 'wss://sri:foobar@example.com:8080?_monkeybiz%3B=&_monkey=&23=#23',
   'right format';
+$url = Mojo::URL->new('https://example.com/0?0#0');
+ok $url->is_abs,   'is absolute';
+is $url->scheme,   'https', 'right scheme';
+is $url->userinfo, undef, 'no userinfo';
+is $url->host,     'example.com', 'right host';
+is $url->port,     undef, 'no port';
+is $url->path,     '/0', 'no path';
+is $url->query,    '0', 'right query';
+is $url->fragment, '0', 'right fragment';
+is "$url", 'https://example.com/0?0#0', 'right format';
 
 # No authority
 $url = Mojo::URL->new('DATA:image/png;base64,helloworld123');