repl: fix space autocompletion bug

Tapping <SP> + <TAB> would exit the REPL.
nodejs · Mar 20, 2012 · 415bff2 · 415bff2
1 parent 1824019
commit 415bff2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -589,6 +589,8 @@ REPLServer.prototype.complete = function(line, callback) {
     } else {
       completionGroupsLoaded();
     }
+  } else {
+    completionGroupsLoaded();
   }
 
   // Will be called when all completionGroups are in place

diff --git a/test/simple/test-repl-tab-complete.js b/test/simple/test-repl-tab-complete.js
@@ -190,3 +190,15 @@ putIn.run([
 testMe.complete('str.len', function(error, data) {
   assert.deepEqual(data, [['str.length'], 'str.len']);
 });
+
+putIn.run(['.clear']);
+
+// tab completion should not break on spaces
+var spaceTimeout = setTimeout(function() {
+  throw new Error('timeout');
+}, 1000);
+
+testMe.complete(' ', function(error, data) {
+  assert.deepEqual(data, [[],undefined]);
+  clearTimeout(spaceTimeout);
+});