Trunk 4156 redesigned #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 3, 2014 12:04
1. Introduce new care_setting table. 2. Replace existing care_setting varchar to care_setting_id referencing the care_setting table. 3. Make OUTPATIENT as default care_setting for existing orders that do not have a care_setting. 4. Introduce new method in OrderService. This fixes a test and provides a way to retrieve a care setting.
|
|
||
| public static CareSetting OUTPATIENT = new CareSetting(OUT_PATIENT); | ||
| private CareSettingType careSettingType = CareSettingType.OUTPATIENT; |
There was a problem hiding this comment.
I don't think you should be setting a default value here, just leave it null
| </insert> | ||
| </changeSet> | ||
|
|
||
| <changeSet id="201312271825-TRUNK-4156" author="vinay"> |
There was a problem hiding this comment.
You don't need to be dropping this column with liquibase here since it doean't exist in a release openmrs version, just drop it with sql from your local mysql instance. I will fix this as i merge the code
|
You forgot to change the column names for orders.care_setting and care_setting.care_setting_type in the hbm and test data files, i will fix that as i merge the code too |
|
Merged the code at 3863412 |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
The idea here is to ensure that failing to load a script complains loudly but doesn't break the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Commit 8dd08a1 is a minor fix with the existing liquibasechangelog (unrelated to the story, but we cannot work without it).
-Vinay