Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: d0227b03083a
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 18beea4a3f89
Choose a head ref
  • 7 commits
  • 5 files changed
  • 4 contributors

Commits on Oct 21, 2012

  1. test: add diffie-hellman regression test

    Exercises the error path in DiffieHellman::ComputeSecret() in src/node_crypto.cc
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    82df345 View commit details
    Browse the repository at this point in the history
  2. crypto: fix DH 1 byte buffer underflow

    Passing a bad key to DiffieHellman::ComputeSecret() made it zero the byte
    before the heap allocated buffer due to an erroneous size calculation.
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    de18e29 View commit details
    Browse the repository at this point in the history
  3. crypto: fix DH use-after-free and memory leak

    Fix a use-after-free bug and a memory leak in the error path of
    DiffieHellman::ComputeSecret().
    
    * the BIGNUM key was used after being freed with BN_free().
    * the output buffer was not freed
    bnoordhuis committed Oct 21, 2012
    Copy the full SHA
    844a005 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2012

  1. v8: use correct timezone information on Solaris

    `timezone` variable contains the difference, in seconds, between UTC and
    local standard time (see `man 3 localtime` on Solaris).
    
    Call to `tzset` is required to apply contents of `TZ` variable to
    `timezone` variable.
    
    BUG=v8:2064
    
    Review URL: https://chromiumcodereview.appspot.com/10967066
    Patch from Maciej Małecki <me@mmalecki.com>.
    
    This is a back-port of upstream commit r12802.
    hashseed authored and bnoordhuis committed Oct 23, 2012
    Copy the full SHA
    9fa953d View commit details
    Browse the repository at this point in the history
  2. typed arrays: use signed char for signed int8s

    The C standard allows plain `char` to be unsigned. The build environment
    at Google trips this issue.
    jacobsa authored and bnoordhuis committed Oct 23, 2012
    Copy the full SHA
    49f0f61 View commit details
    Browse the repository at this point in the history
  3. test: add typed arrays regression test

    Ensure that uint8 values >= 128 are correctly promoted to int8 <= -1.
    bnoordhuis committed Oct 23, 2012
    Copy the full SHA
    b6b8813 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    18beea4 View commit details
    Browse the repository at this point in the history