Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Hashable to hash diagram code and options instead of Show and rolling our own #5

Closed
byorgey opened this issue Sep 4, 2013 · 2 comments
Assignees

Comments

@byorgey
Copy link
Member

byorgey commented Sep 4, 2013

Right now to hash stuff we use Show and then do something like MD5 on the resulting String. Instead we really ought to just use Hashable (from the hashable package) directly. Note this would involve adding Hashable instances for the options records of all the backends supported by diagrams-builder as well.

@byorgey
Copy link
Member Author

byorgey commented Nov 28, 2013

Working on this now. See the cleanup branch.

@bergey
Copy link
Member

bergey commented Jul 3, 2014

closed in c93a65b

@bergey bergey closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants