added url method to Mojo::DOM

mojolicious · Dec 21, 2014 · 9293d3a · 9293d3a · s1037989 · Dec 21, 2014
1 parent 398f499
commit 9293d3a
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/lib/Mojo/DOM.pm b/lib/Mojo/DOM.pm
@@ -13,6 +13,7 @@ use Carp 'croak';
 use Mojo::Collection;
 use Mojo::DOM::CSS;
 use Mojo::DOM::HTML;
+use Mojo::URL;
 use Mojo::Util qw(deprecated squish);
 use Scalar::Util qw(blessed weaken);
 
@@ -184,6 +185,15 @@ sub type {
   return $self;
 }
 
+sub url {
+  my $self = shift;
+  for my $attr (@_ ? @_ : qw/href src/) {
+    next unless my $url = $self->attr($attr);
+    return Mojo::URL->new($url);
+  }
+  return undef;
+}
+
 # DEPRECATED in Tiger Face!
 sub val {
   deprecated 'Mojo::DOM::val is DEPRECATED';
@@ -913,6 +923,18 @@ This element's type.
   # List types of child elements
   say $dom->children->map('type')->join("\n");
 
+=head2 url
+
+  my $url = $dom->url;
+  my $url = $dom->url(qw/myattr href src/);
+
+Returns a L<Mojo::URL> object for the C<href> or C<src> attribute of the node
+or C<undef> if the node does not have the attributes. Optionally pass a list of
+alternative attributes to search.
+
+  # "bender"
+  $dom->parse('<a href="/page.html#bender"></a>')->at('a')->url->fragment;
+
 =head2 wrap
 
   $dom = $dom->wrap('<div></div>');

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -2393,4 +2393,17 @@ $dom = Mojo::DOM->new($huge);
 is $dom->all_text, 'works', 'right text';
 is "$dom", $huge, 'right result';
 
+# url
+$dom = Mojo::DOM->new('<a href="http://mojolicio.us">Mojo</a>');
+my $url = $dom->at('a')->url;
+isa_ok $url, 'Mojo::URL';
+is $url->to_string, 'http://mojolicio.us', 'right url content';
+$dom = Mojo::DOM->new('<img src="/image.png"></img>')->at('img');
+is $dom->url('src')->path->parts->[-1], 'image.png', 'found src';
+
+$dom = Mojo::DOM->new('<img src="/image.png" href="/page.html"></img>')->at('img');
+is $dom->url->path->parts->[-1], 'page.html', 'found href';
+is $dom->url('src')->path->parts->[-1], 'image.png', 'found src';
+is $dom->url('myattr'), undef, 'attribute not found';
+
 done_testing();