Better JMS format #178
Better JMS format #178
Conversation
| node.addMixin(FEDORA_OBJECT); | ||
| session.save(); | ||
|
|
||
| waitForEntry(1); |
There was a problem hiding this comment.
Maybe it would be better to just do the loop/waiting for the test below instead of counting messages? It seems like that should be more robust than counting messages.
There was a problem hiding this comment.
The question is, when are you done? If you don't stop waiting because you know you have enough messages, you must wait for a timeout.
The alternative would be to do a loop and check each message as it comes in to see if it fulfills the test... would you find that better? I can do that, and that would eliminate the counting (which I completely agree is brittle at best).
There was a problem hiding this comment.
Yes, I think looping and checking to see if the test is fulfilled would be better -- more direct and fewer ways to break.
There was a problem hiding this comment.
Ok, new commit on the way.
Better JMS format Fixes https://www.pivotaltracker.com/story/show/45629439
Introduces a new, more lightweight alternative message format.