Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 9576d0965442
Choose a base ref
...
head repository: jruby/jruby
compare: 54eace247ded
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 7, 2014

  1. Additional cleanup for IO#close exception handling after blocks.

    @headius
    headius committed Nov 7, 2014
    Copy the full SHA
    a7878d0 View commit details
    Browse the repository at this point in the history

  2. Try to use an existing ChannelFD for native FDs, for close logic. 

    If we create a new NativeDeviceChannel and ChannelFD, we lose the
closed flag on the NIO channel that would raise an IOException.
Instead, the lower levels of NIO close logic must swallow the
EBADF we expect, and it never gets raised. This is likely a bad
expectation on the part of NIO channel close logic, since the
underlying fd *is* closed, but the channel does not know it.
    @headius
    headius committed Nov 7, 2014
    Copy the full SHA
    76242f4 View commit details
    Browse the repository at this point in the history

  3. Make RubyIO.toString use inspect output.

    @headius
    headius committed Nov 7, 2014
    Copy the full SHA
    de133c9 View commit details
    Browse the repository at this point in the history

  4. Mask out missing parser warning failures. #2124

    @headius
    headius committed Nov 7, 2014
    Copy the full SHA
    54eace2 View commit details
    Browse the repository at this point in the history