-
Notifications
You must be signed in to change notification settings - Fork 605
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rubinius/rubinius
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fbaafa65ea49^
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rubinius/rubinius
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e25088a37f27
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 3 files changed
- 1 contributor
Commits on Jan 4, 2015
-
Added simple spec for Process::Status#initialize.
While MRI removes the `new` method from Process::Status we _do_ have this method (and an initialize method) that perform certain actions worth testing. More importantly, this way we can ensure that this class can be initialized from C in a similar fashion to MRI. See #3268 for more information.
Yorick Peterse committedJan 4, 2015 Configuration menu - View commit details
-
Copy full SHA for fbaafa6 - Browse repository at this point
Copy the full SHA fbaafa6View commit details -
Make Process::Status#initialize arguments optional
This ensures that the class can be initialized in a similar fashion to MRI (mainly from C land) while still keeping it compatible with existing Rubinius code.
Yorick Peterse committedJan 4, 2015 Configuration menu - View commit details
-
Copy full SHA for 1ac896d - Browse repository at this point
Copy the full SHA 1ac896dView commit details -
Added specs for Process::Status#exitstatus.
Yorick Peterse committedJan 4, 2015 Configuration menu - View commit details
-
Copy full SHA for ee3cf92 - Browse repository at this point
Copy the full SHA ee3cf92View commit details -
Use "status" ivar in Process::Status.
MRI stores the status code in an instance variable called "@status" instead of "@ExitStatus". Due to the lack of a proper API to set this variable people instead have to resort to setting it via rb_ivar_set() in C. To ensure compatibility with MRI we sadly also have to name this variable in the same way. Due to the variable being renamed the method "exitstatus" now has to be manually defined, instead of just being an attribute reader. See #3268 for more information.
Yorick Peterse committedJan 4, 2015 Configuration menu - View commit details
-
Copy full SHA for e25088a - Browse repository at this point
Copy the full SHA e25088aView commit details
There are no files selected for viewing