Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
base: fbaafa65ea49^
Choose a base ref
...
head repository: rubinius/rubinius
compare: e25088a37f27
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 4, 2015

  1. Added simple spec for Process::Status#initialize. 

    While MRI removes the `new` method from Process::Status we _do_ have this method
(and an initialize method) that perform certain actions worth testing. More
importantly, this way we can ensure that this class can be initialized from C in
a similar fashion to MRI.

See #3268 for more information.
    Yorick Peterse committed Jan 4, 2015
    Copy the full SHA
    fbaafa6 View commit details
    Browse the repository at this point in the history

  2. Make Process::Status#initialize arguments optional 

    This ensures that the class can be initialized in a similar fashion to MRI
(mainly from C land) while still keeping it compatible with existing Rubinius
code.
    Yorick Peterse committed Jan 4, 2015
    Copy the full SHA
    1ac896d View commit details
    Browse the repository at this point in the history

  3. Added specs for Process::Status#exitstatus.

    Yorick Peterse committed Jan 4, 2015
    Copy the full SHA
    ee3cf92 View commit details
    Browse the repository at this point in the history

  4. Use "status" ivar in Process::Status. 

    MRI stores the status code in an instance variable called "@status" instead of
"@ExitStatus". Due to the lack of a proper API to set this variable people
instead have to resort to setting it via rb_ivar_set() in C. To ensure
compatibility with MRI we sadly also have to name this variable in the same way.

Due to the variable being renamed the method "exitstatus" now has to be manually
defined, instead of just being an attribute reader.

See #3268 for more information.
    Yorick Peterse committed Jan 4, 2015
    Copy the full SHA
    e25088a View commit details
    Browse the repository at this point in the history