Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 4eeb9e6b6c45
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: cd5418cff2b0
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Feb 26, 2015

  1. src: fix builtin modules failing with --use-strict 

    Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when
--use-strict is passed to node. In addition to that, console.trace
throws because it uses arguments.callee.

This change fixes these issues and adds a test that makes sure
every external built-in module can be loaded with require when
--use-strict is enabled.

Please note that this change does not fix all issues with built-in
modules' code running with --use-strict. It is very likely that some
code in the built-in modules still fails when passing this flag.

However, fixing all code would require us to enable strict mode by
default in all builtins modules, which would certainly break existing
applications.

Fixes #9187.

Reviewed-By:
PR-URL: #9237
    Julien Gilli committed Feb 26, 2015
    Copy the full SHA
    cd5418c View commit details
    Browse the repository at this point in the history