Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 5383e7588520
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ea7b81726651
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Aug 4, 2013

  1. tls: fix handling of SNICallback server option 

    It shouldn't ignore it!

There're two possibile cases, which should be handled properly:

1. Having a default `SNICallback` which is using contexts, added with
  `server.addContext(...)` routine
2. Having a custom `SNICallback`.

In first case we may want to opt-out setting `.onsniselect` method (and
thus save some CPU time), if there're no contexts added. But, if custom
`SNICallback` is used, `.onsniselect` should always be set, because
server contexts don't affect it.
    @indutny
    indutny committed Aug 4, 2013
    Copy the full SHA
    ea7b817 View commit details
    Browse the repository at this point in the history