small optimizations

mojolicious · Aug 12, 2014 · dee284f · dee284f
1 parent eceba70
commit dee284f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,5 @@
 
-5.28  2014-08-12
+5.28  2014-08-13
   - Improved performance of nested helpers and helpers in templates
     significantly.
   - Improved Mojo::JSON to generate smaller JSON by not escaping the "/"

diff --git a/lib/Mojolicious/Plugin/EPRenderer.pm b/lib/Mojolicious/Plugin/EPRenderer.pm
@@ -11,8 +11,8 @@ sub register {
 
   # Auto escape by default to prevent XSS attacks
   my $template = {auto_escape => 1, %{$conf->{template} || {}}};
-  $self->{namespace} = $template->{namespace}
-    //= 'Mojo::Template::Sandbox::' . md5_sum("$self");
+  my $ns = $self->{namespace} = $template->{namespace}
+    //= 'Mojo::Template::Sandbox::' . md5_sum "$self";
 
   # Add "ep" handler and make it the default
   $app->renderer->default_handler('ep')->add_handler(
@@ -38,15 +38,15 @@ sub register {
 
         # Stash values (every time)
         my $prepend = 'my $self = my $c = shift; my $_S = $c->stash;';
-        $prepend .= " my \$$_ = \$_S->{'$_'};" for @keys;
+        $prepend .= join '', map {" my \$$_ = \$_S->{'$_'};"} @keys;
 
         $cache->set($key => $mt->prepend($prepend . $mt->prepend));
       }
 
       # Make current controller available
       no strict 'refs';
       no warnings 'redefine';
-      local *{"@{[$mt->namespace]}::_C"} = sub {$c};
+      local *{"${ns}::_C"} = sub {$c};
 
       # Render with "epl" handler
       return $renderer->handlers->{epl}->($renderer, $c, $output, $options);
@@ -55,10 +55,10 @@ sub register {
 }
 
 sub _helpers {
-  my ($ns, $helpers) = @_;
-  for my $name (grep {/^\w+$/} keys %$helpers) {
-    my $sub = $helpers->{$name};
-    monkey_patch $ns, $name, sub { $ns->_C->$sub(@_) };
+  my ($class, $helpers) = @_;
+  for my $method (grep {/^\w+$/} keys %$helpers) {
+    my $sub = $helpers->{$method};
+    monkey_patch $class, $method, sub { $class->_C->$sub(@_) };
   }
 }
 

diff --git a/lib/Mojolicious/Renderer.pm b/lib/Mojolicious/Renderer.pm
@@ -75,7 +75,7 @@ sub get_helper {
   if (my $h = $self->helpers->{$name} || $self->{proxy}{$name}) { return $h }
 
   my $found;
-  my $class = 'Mojolicious::Renderer::Helpers::' . md5_sum("$name:$self");
+  my $class = 'Mojolicious::Renderer::Helpers::' . md5_sum "$name:$self";
   for my $key (keys %{$self->helpers}) {
     $key =~ /^(\Q$name\E\.([^.]+))/ ? ($found, my $method) = (1, $2) : next;
     my $sub = $self->get_helper($1);