New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRUNK-2999: Investigate replacing concept word with full text search #126
Conversation
<groupId>org.hibernate</groupId> | ||
<artifactId>hibernate-search-analyzers</artifactId> | ||
<groupId>org.apache.lucene</groupId> | ||
<artifactId>lucene-queries</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped using this, so it can be removed.
… hibernate-search Conflicts: api/src/main/java/org/openmrs/api/context/Context.java
private String name; | ||
|
||
@Field(index = Index.UN_TOKENIZED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't UN_TOKENIZED the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the default is to use StandardAnalyzer with a tokenizer.
/** | ||
* | ||
*/ | ||
public abstract class CollectionPart<E> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some javadocs and @SInCE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
… hibernate-search
@rkorytkowski do we plan to merge this pull request? :) |
@rkorytkowski feel free to reopen if we still need this pull request. :) |
SonarCloud Quality Gate failed. |
* Add Markdown link check to GitHub Actions * Fix broken links
Please do NOT merge. It is only for review.
https://tickets.openmrs.org/browse/TRUNK-2999