Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 41d3e68feab5
Choose a base ref
...
head repository: cdk/cdk
compare: d8712bb83baa
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 7, 2013

  1. Using the bootstrap seems to cause regressions. 

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Aug 7, 2013
    Copy the full SHA
    0f410dc View commit details
    Browse the repository at this point in the history

  2. Avoid set the atomic number twice. Previously invoking 'new Element("… 

    …H", null)' would still set the atomic number to '1'. Chaining the constructors so that all fields are assigned in the same places avoids this problem.

Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Aug 7, 2013
    Copy the full SHA
    d8712bb View commit details
    Browse the repository at this point in the history