Fix Sonar major issues #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed string buffer for string appends - fixed static inner class - fixed Locale Resolves: https://jira.duraspace.org/browse/FCREPO-1337
Partial resolution of: https://jira.duraspace.org/browse/FCREPO-1338
…ed-out lines of code" Resolves: https://jira.duraspace.org/browse/FCREPO-1332
…rencing, indirectly invoked but otherwise unused variable, etc. Resolves: https://jira.duraspace.org/browse/FCREPO-1335 Addressed in this PR: - Unused private method 1 file: http://sonar.fcrepo.org/drilldown/issues/1?&rule=squid%3AUnusedPrivateMethod&rule_sev=MAJOR&severity=MAJOR - Singular Field 1 file: http://sonar.fcrepo.org/drilldown/issues/1?&rule=pmd%3ASingularField&rule_sev=MAJOR&severity=MAJOR - Correctness - Nullcheck of value previously dereferenced 1 file: http://sonar.fcrepo.org/drilldown/issues/1?&rule=findbugs%3ARCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE&rule_sev=MAJOR&severity=MAJOR - Empty arrays and collections should be returned instead of null 1 file: http://sonar.fcrepo.org/drilldown/issues/1?&rule=squid%3AS1168&rule_sev=MAJOR&severity=MAJOR Update PR
| @@ -354,7 +354,7 @@ private String doBackwardPathOnly(final FedoraResource resource) { | |||
| if (path != null) { | |||
|
|
|||
| if (resource instanceof NonRdfSourceDescription) { | |||
| path = path + "/" + FCR_METADATA; | |||
| path += "/" + FCR_METADATA; | |||
There was a problem hiding this comment.
The Sonar recommendation is to use a StringBuffer instead of String concatenation. Your update is a different syntax for the same String concatenation.
In any case, the performance impact of String concatenation is tolerable here, and no update is needed.
- fixed string buffer for string appends - fixed static inner class - fixed Locale Resolves: https://jira.duraspace.org/browse/FCREPO-1337
… into fcrepo-1337 Conflicts: fcrepo-http-commons/src/main/java/org/fcrepo/http/commons/api/rdf/HttpResourceConverter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.duraspace.org/browse/FCREPO-1337