Add error checking to relationship start/end dates on patient dashboard - TRUNK-3293 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought you needed to add a validator and do this validation on the server side |
| @@ -192,6 +192,10 @@ | |||
| var relId = $j("#editRelationship #edit_relationship_id").val(); | |||
| var startDate = $j("#editRelationship #edit_rel_start_date").val(); | |||
| var endDate = $j("#editRelationship #edit_rel_end_date").val(); | |||
| if (Date.parse(startDate) > Date.parse(endDate)) { | |||
There was a problem hiding this comment.
This is not correct. startDate and endDate may not be in a format that parse expects. I'd validate it on the server side.
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…sts (openmrs#103) * Disable workbox logging by default. * Added a global event for failed network requests. * Fixed line endings. * Prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://tickets.openmrs.org/browse/TRUNK-3293