Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the error message to be equal to the error in ruby variable.c #3323

Closed
wants to merge 1 commit into from

Conversation

@yorickpeterse
Copy link
Contributor

Is it known why Psych is depending on the exact error message? Generally this isn't part of the compatibility layer, even MRI changes these between minor releases at times.

@brixen
Copy link
Member

brixen commented Feb 20, 2015

@bjfish please send a PR to that project to fix their dependency on verbatim MRI error messages. There are many reasons not to depend on the exact text of an error message. The proper solution for exception objects is to add accessors that provide the information needed.

Rubinius needs to be free to improve the quality of the error message text. Code should use proper language facilities and not try parsing text.

@brixen brixen closed this Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants