Set default PDL::NiceSlice engine to Filter::Simple

This will allow us to exercise the new implementation while the same is implemented for the string evals as in the PDL shells (perldl, pdl2,...)
PDLPorters · Feb 22, 2015 · dfdef89 · dfdef89
1 parent a5b1dd7
commit dfdef89
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Basic/SourceFilter/NiceSlice.pm b/Basic/SourceFilter/NiceSlice.pm
@@ -5,9 +5,9 @@ BEGIN {
       'Module::Compile'     => 'PDL/NiceSlice/ModuleCompile.pm',
    );  # to validate names
 
-   ## $PDL::NiceSlice::engine = $engine_ok{'Filter::Simple'};  # default engine type
+   $PDL::NiceSlice::engine = $engine_ok{'Filter::Simple'};  # default engine type
    ## TODO: Add configuration argument to perldl.conf
-   $PDL::NiceSlice::engine = $engine_ok{'Filter::Util::Call'};  # default engine type
+   ## $PDL::NiceSlice::engine = $engine_ok{'Filter::Util::Call'};  # default engine type
 
    if ( exists $ENV{PDL_NICESLICE_ENGINE} ) {
       my $engine = $ENV{PDL_NICESLICE_ENGINE};

diff --git a/Release_Notes b/Release_Notes
@@ -35,7 +35,11 @@ General Notes:
 
 Highlights:
 
- * TBD
+ * The new Filter::Simple engine for PDL::NiceSlice is now
+   the default.  This fixes problems where PDL::NiceSlice
+   was applying the sourcefilter to the content of comments
+   and strings.  Still to do: implement for command line use
+   in perldl/pdl2 shells.