Fix some memory leaks on packet sending.

nerzhul · nerzhul · commit 009149a073ac · 2015-02-21T17:27:31.000+01:00
diff --git a/src/client.cpp b/src/client.cpp
@@ -956,6 +956,7 @@ void Client::Send(NetworkPacket* pkt)
 		serverCommandFactoryTable[pkt->getCommand()].channel,
 		pkt,
 		serverCommandFactoryTable[pkt->getCommand()].reliable);
+	delete pkt;
 }
 
 void Client::interact(u8 action, const PointedThing& pointed)
diff --git a/src/network/connection.cpp b/src/network/connection.cpp
@@ -1729,6 +1729,7 @@ void ConnectionSendThread::connect(Address address)
 	m_connection->SetPeerID(PEER_ID_INEXISTENT);
 	NetworkPacket* pkt = new NetworkPacket(0,0);
 	m_connection->Send(PEER_ID_SERVER, 0, pkt, true);
+	delete pkt;
 }
 
 void ConnectionSendThread::disconnect()
diff --git a/src/server.cpp b/src/server.cpp
@@ -2079,24 +2079,19 @@ void Server::sendRemoveNode(v3s16 p, u16 ignore_id,
 	float maxd = far_d_nodes*BS;
 	v3f p_f = intToFloat(p, BS);
 
-	NetworkPacket* pkt = new NetworkPacket(TOCLIENT_REMOVENODE, 2 + 2 + 2);
+	NetworkPacket* pkt = new NetworkPacket(TOCLIENT_REMOVENODE, 6);
 	*pkt << p;
 
 	std::list<u16> clients = m_clients.getClientIDs();
 	for(std::list<u16>::iterator
 		i = clients.begin();
-		i != clients.end(); ++i)
-	{
-		if(far_players)
-		{
+		i != clients.end(); ++i) {
+		if(far_players) {
 			// Get player
-			Player *player = m_env->getPlayer(*i);
-			if(player)
-			{
+			if(Player *player = m_env->getPlayer(*i)) {
 				// If player is far away, only set modified blocks not sent
 				v3f player_pos = player->getPosition();
-				if(player_pos.getDistanceFrom(p_f) > maxd)
-				{
+				if(player_pos.getDistanceFrom(p_f) > maxd) {
 					far_players->push_back(*i);
 					continue;
 				}
@@ -2118,7 +2113,7 @@ void Server::sendAddNode(v3s16 p, MapNode n, u16 ignore_id,
 	v3f p_f = intToFloat(p, BS);
 
 	std::list<u16> clients = m_clients.getClientIDs();
-		for(std::list<u16>::iterator
+	for(std::list<u16>::iterator
 			i = clients.begin();
 			i != clients.end(); ++i)
 		{
@@ -2139,7 +2134,7 @@ void Server::sendAddNode(v3s16 p, MapNode n, u16 ignore_id,
 			}
 		}
 
-		NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ADDNODE, 0);
+		NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ADDNODE, 6 + 2 + 1 + 1 + 1);
 		m_clients.Lock();
 		RemoteClient* client = m_clients.lockedGetClientNoEx(*i);
 		if (client != 0) {
diff --git a/src/test.cpp b/src/test.cpp
@@ -2010,6 +2010,8 @@ struct TestConnection: public TestBase
 					<< std::endl;
 
 			UASSERT(memcmp(*sentdata, *recvdata, recvdata.getSize()) == 0);
+
+			delete pkt;
 		}
 
 		u16 peer_id_client = 2;
@@ -2074,6 +2076,8 @@ struct TestConnection: public TestBase
 
 			UASSERT(memcmp(*sentdata, *recvdata, recvdata.getSize()) == 0);
 			UASSERT(peer_id == PEER_ID_SERVER);
+
+			delete pkt;
 		}
 
 		// Check peer handlers

Original file line number	Diff line number	Diff line change
`@@ -956,6 +956,7 @@ void Client::Send(NetworkPacket* pkt)`
`956`	`956`	`serverCommandFactoryTable[pkt->getCommand()].channel,`
`957`	`957`	`pkt,`
`958`	`958`	`serverCommandFactoryTable[pkt->getCommand()].reliable);`
	`959`	`+ delete pkt;`
`959`	`960`	`}`
`960`	`961`
`961`	`962`	`void Client::interact(u8 action, const PointedThing& pointed)`
Original file line number	Diff line number	Diff line change
`@@ -1729,6 +1729,7 @@ void ConnectionSendThread::connect(Address address)`
`1729`	`1729`	`m_connection->SetPeerID(PEER_ID_INEXISTENT);`
`1730`	`1730`	`NetworkPacket* pkt = new NetworkPacket(0,0);`
`1731`	`1731`	`m_connection->Send(PEER_ID_SERVER, 0, pkt, true);`
	`1732`	`+ delete pkt;`
`1732`	`1733`	`}`
`1733`	`1734`
`1734`	`1735`	`void ConnectionSendThread::disconnect()`
Original file line number	Diff line number	Diff line change
`@@ -2010,6 +2010,8 @@ struct TestConnection: public TestBase`
`2010`	`2010`	`<< std::endl;`
`2011`	`2011`
`2012`	`2012`	`UASSERT(memcmp(sentdata, recvdata, recvdata.getSize()) == 0);`
	`2013`	`+`
	`2014`	`+ delete pkt;`
`2013`	`2015`	`}`
`2014`	`2016`
`2015`	`2017`	`u16 peer_id_client = 2;`
`@@ -2074,6 +2076,8 @@ struct TestConnection: public TestBase`
`2074`	`2076`
`2075`	`2077`	`UASSERT(memcmp(sentdata, recvdata, recvdata.getSize()) == 0);`
`2076`	`2078`	`UASSERT(peer_id == PEER_ID_SERVER);`
	`2079`	`+`
	`2080`	`+ delete pkt;`
`2077`	`2081`	`}`
`2078`	`2082`
`2079`	`2083`	`// Check peer handlers`