Fix #14188: SOAP update function accesses undefined variable in error handling

atrol · atrol · commit 1eaaeff3bee9 · 2012-04-24T22:01:05.000+02:00
diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
@@ -748,6 +748,7 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 		if ( isset( $p_issue['category'] ) && !is_blank( $p_issue['category'] ) ) {
 			return new soap_fault( 'Client', '', "Category field must be supplied." );
 		} else {
+			$t_project_name = project_get_name( $t_project_id );
 			return new soap_fault( 'Client', '', "Category '" . $p_issue['category'] . "' not found for project '$t_project_name'." );
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -748,6 +748,7 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {`
`748`	`748`	`if ( isset( $p_issue['category'] ) && !is_blank( $p_issue['category'] ) ) {`
`749`	`749`	`return new soap_fault( 'Client', '', "Category field must be supplied." );`
`750`	`750`	`} else {`
	`751`	`+ $t_project_name = project_get_name( $t_project_id );`
`751`	`752`	`return new soap_fault( 'Client', '', "Category '" . $p_issue['category'] . "' not found for project '$t_project_name'." );`
`752`	`753`	`}`
`753`	`754`	`}`