[Truffle] Implemented Symbol#upcase, added final in Symbol#swapcase #2621
Conversation
| @@ -241,7 +241,28 @@ public SwapcaseNode(SwapcaseNode prev) { | |||
| public RubySymbol swapcase(RubySymbol symbol) { | |||
| notDesignedForCompilation(); | |||
|
|
|||
| ByteList byteList = StringNodes.StringNodesHelper.swapcase(symbol.toRubyString()); | |||
| final ByteList byteList = StringNodes.StringNodesHelper.swapcase(symbol.toRubyString()); | |||
There was a problem hiding this comment.
Converting to a RubyString isn't ideal - it would be good if we could just use the ByteList directly. When we are using the JIT compiler the RubyString wrapper object would not be allocated, but in the interpreter it's a little bit of overhead.
|
@chrisseaton Thanks for the feedback. I made some fixes. Are there any more updates needed? |
…that are now passing
| byteList.set(i, c ^ 0x20); | ||
| } | ||
| } | ||
| return byteList; |
There was a problem hiding this comment.
Did you write this from scratch or did it come from the main JRuby code? I'd be surprised if they don't already have a routine we could copy for this.
There was a problem hiding this comment.
This was from scratch, Check out this for upcase
There was a problem hiding this comment.
The presence of multiByteUpcase
However, we'll go by the specs for now.
[Truffle] Implemented Symbol#upcase, added final in Symbol#swapcase
Reference String#upcase for implementation