fixed empty attribute bug in Mojo::DOM::CSS

mojolicious · Jul 29, 2013 · 310a98a · 310a98a
1 parent db1c60a
commit 310a98a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 
 4.22  2013-07-30
   - Improved Mojo::Server to use FindBin more defensively.
+  - Fixed empty attribute bug in Mojo::DOM::CSS.
   - Fixed partial route handling in routes command.
 
 4.21  2013-07-29

diff --git a/lib/Mojo/DOM/CSS.pm b/lib/Mojo/DOM/CSS.pm
@@ -10,7 +10,7 @@ my $ATTR_RE   = qr/
   (?:
     (\W)?                         # Operator
     =
-    (?:"((?:\\"|[^"])+)"|(\S+))   # Value
+    (?:"((?:\\"|[^"])*)"|(\S+))   # Value
   )?
   \]
 /x;

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -584,6 +584,12 @@ is $dom->at('[id="><"]')->attr->{id}, '><', 'right attribute';
 $dom = Mojo::DOM->new->parse(qq{<div test="" test2='' />});
 is $dom->at('div')->attr->{test},  '', 'empty attribute value';
 is $dom->at('div')->attr->{test2}, '', 'empty attribute value';
+is $dom->at('[test]')->type,  'div', 'right type';
+is $dom->at('[test2]')->type, 'div', 'right type';
+is $dom->at('[test3]'), undef, 'no result';
+is $dom->at('[test=""]')->type,  'div', 'right type';
+is $dom->at('[test2=""]')->type, 'div', 'right type';
+is $dom->at('[test3=""]'), undef, 'no result';
 
 # Whitespaces before closing bracket
 $dom = Mojo::DOM->new->parse(qq{<div >content</div>});