Improve spec running (rake, in browser and configurable) #36
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fkchang
commented
Feb 24, 2015
fkchang
commented
- get rake opal:spec task working
- change default location of specs outside of asset pipeline,
- handle compilation of files outside of asset pipeline
- make location configurable
- update Readme
outside of asset pipeline, handle compilation of files outside of asset pipeline, make location configurable, update docs
|
I'm keen for this to get merged, but would like @elia thoughts first. Possibly related to this pull request is a small issue I have had before where requiring "opal" from one of my specs (sometimes indirectly by requiring "application", which then requires "opal") is that I get duplicate file issues because So, is there a way we can compact everything into one singular sprockets script tag, to avoid any duplicate files? This seems a good time to get a fix on that as well. |
elia
added a commit
that referenced
this pull request
Feb 24, 2015
Improve spec running (rake, in browser and configurable)
|
awesome thanks! |
|
@adambeynon thinking of replacing the spec controller with a new sprockets env or an opal/builder based rack app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.