Use LaunchConfig to detect sh/cmd commands in popen. Fixes #2505.

jruby · Feb 24, 2015 · 0ca486c · 0ca486c
1 parent 258be73
commit 0ca486c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/util/ShellLauncher.java b/core/src/main/java/org/jruby/util/ShellLauncher.java
@@ -748,7 +748,8 @@ private static Process popenShared(Ruby runtime, IRubyObject[] strings, Map env,
             }
 
             String[] args = parseCommandLine(runtime.getCurrentContext(), runtime, strings);
-            boolean useShell = false;
+            LaunchConfig lc = new LaunchConfig(runtime, strings, false);
+            boolean useShell = lc.shouldRunInShell();
             if (addShell) for (String arg : args) useShell |= shouldUseShell(arg);
 
             // CON: popen is a case where I think we should just always shell out.