Monkey patch flask.jsonify to handle JSONP responses. #167

ralphbean · 2015-02-25T21:03:36Z

I specifically want this for the Fedora releng-dash so it can query at
page-load and find out:

What collections are active and which are EOL.
What collections are "Under development" but not rawhide.. i.e., are
we currently "branched"?

I specifically want this for the Fedora releng-dash so it can query at page-load and find out: - What collections are active and which are EOL. - What collections are "Under development" but not rawhide.. i.e., are we currently "branched"?

pypingou · 2015-02-25T21:12:45Z

pkgdb2/__init__.py

+
+        callback = flask.request.args.get('callback', None)
+
+        if callback:


Could we check that the request is a GET and never a POST? Since the API is r/w I would prefer that we do not support jsonp on POST queries.

Should be done in b0fa924

pypingou · 2015-02-25T21:36:16Z

I was wondering if it makes sense to have it in pkgdb2/__init__py vs having it in pkgdb2/api/__init__.py but while this is only intended for the API endpoint there is no code that restricts it to the /api/ section/blueprint, so won't change much

👍

Monkey patch flask.jsonify to handle JSONP responses.

pypingou reviewed Feb 25, 2015
View reviewed changes

Only do JSONP for GET, never POST.

b0fa924

ralphbean added a commit that referenced this pull request Feb 25, 2015

Merge pull request #167 from fedora-infra/jsonp

fd67ed6

Monkey patch flask.jsonify to handle JSONP responses.

ralphbean merged commit fd67ed6 into master Feb 25, 2015

ralphbean deleted the jsonp branch February 25, 2015 22:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monkey patch flask.jsonify to handle JSONP responses. #167

Monkey patch flask.jsonify to handle JSONP responses. #167

ralphbean commented Feb 25, 2015

pypingou Feb 25, 2015

ralphbean Feb 25, 2015

ralphbean Feb 25, 2015

pypingou commented Feb 25, 2015


		callback = flask.request.args.get('callback', None)

		if callback:

Monkey patch flask.jsonify to handle JSONP responses. #167

Monkey patch flask.jsonify to handle JSONP responses. #167

Conversation

ralphbean commented Feb 25, 2015

pypingou Feb 25, 2015

Choose a reason for hiding this comment

ralphbean Feb 25, 2015

Choose a reason for hiding this comment

ralphbean Feb 25, 2015

Choose a reason for hiding this comment

pypingou commented Feb 25, 2015