Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: b5f9779c2f83
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: a22a2d865641
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 26, 2014

  1. tls: stop NodeBIO::Gets from reading off end of buffer 

    NodeBIO::Gets was reading off the end of a buffer if it
didn't find a "\n" before the EOF.  This behavior
was causing X509 certificates passed to `https.Agent`
via the "ca" option to be silently discarded. It also
was causing improper parsing of certs and keys
passed to https.Agent, but those problems were worked
around in cdde9a3.

Backed out workaround in `lib/crypto.js` from ccde9a3,
which now isn't needed.  But keep the test introduced
in that commit, which tests properly for this
bug.

This bug was first introduced in a58f93f

Gist containing test code, bisection log, and notes:
   https://gist.github.com/maxtaco/9211605
    @maxtaco @indutny
    maxtaco authored and indutny committed Feb 26, 2014
    Copy the full SHA
    a22a2d8 View commit details
    Browse the repository at this point in the history