Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9912dec06433
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d0aaf2fd8b70
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 25, 2015

  1. Fix 'Cleanup Module#define_method' refucktor

    @vais
    vais committed Feb 25, 2015
    Copy the full SHA
    3043f4e View commit details

  2. Merge pull request #708 from vais/fix_define_method 

    Fix 'Cleanup Module#define_method' refucktor
    @elia
    elia committed Feb 25, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    d0aaf2f View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 opal/corelib/module.rb
4 changes: 2 additions & 2 deletions opal/corelib/module.rb
View file
Original file line number Diff line number Diff line change
@@ -284,10 +284,10 @@ def define_method(name, method = nil, &block)
block.$$def = block;
if (self.$$is_singleton) {
self.$$proto[jsid] = block;
self.$$proto[id] = block;
}
else {
Opal.defn(self, jsid, block);
Opal.defn(self, id, block);
}
return name;