Removed some unused local variables (PMD reports). #50
Conversation
| @@ -92,7 +92,6 @@ public IReaction initiate(IAtomContainerSet atomContainerSet, ArrayList<IAtom> a | |||
| IAtom atom1 = atomList.get(0);// Atom with the charge | |||
| IAtom atom1C = reactantCloned.getAtom(molecule.getAtomNumber(atom1)); | |||
| IAtom atom2 = atomList.get(1);// Atom not participating | |||
There was a problem hiding this comment.
atom2 was only used by the line that has now been removed - I've fixed this up in the commit.
There was a problem hiding this comment.
Hi John,
Thanks for spotting that - I tend to leave these to be found on the next PMD iteration...
Mark
From: John May
Sent: Monday, September 01, 2014 3:39 PM
To: cdk/cdk
Cc: mbv31602
Subject: Re: [cdk] Removed some unused local variables (PMD reports). (#50)
In base/reaction/src/main/java/org/openscience/cdk/reaction/mechanism/RearrangementChargeMechanism.java:
@@ -92,7 +92,6 @@ public IReaction initiate(IAtomContainerSet atomContainerSet, ArrayList a
IAtom atom1 = atomList.get(0);// Atom with the charge
IAtom atom1C = reactantCloned.getAtom(molecule.getAtomNumber(atom1));
IAtom atom2 = atomList.get(1);// Atom not participating
atom2 was only used by the line that has now been removed - I've fixed this up in the commit.
—
Reply to this email directly or view it on GitHub.
|
Applied and pushed (modified commit with comment above). |
ghost
deleted the
No description provided.