Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flatiron/director
base: 3f611351ecc6
Choose a base ref
...
head repository: flatiron/director
compare: 04415421c26c
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 25, 2012

  1. Fix all but the last test in IE. 

    IE returns '#' for `document.location.hash` when that's what the address bar shows, whereas all other browsers return ''. Director's current check-for-empty logic assumes that the browser will do the '#' to '' conversion, so I encapsulated the isEmpty check into something that doesn't make that assumption.
    @domenic
    domenic committed Aug 25, 2012
    Copy the full SHA
    0b7c36b View commit details
    Browse the repository at this point in the history

  2. Fix global variable.

    @domenic
    domenic committed Aug 25, 2012
    Copy the full SHA
    502729e View commit details
    Browse the repository at this point in the history

  3. Close tags in test harness.

    @domenic
    domenic committed Aug 25, 2012
    Copy the full SHA
    e648df1 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #137 from domenic/ie-again 

    Make it work in IE, almost completely
    @pksunkara
    pksunkara committed Aug 25, 2012
    Copy the full SHA
    0441542 View commit details
    Browse the repository at this point in the history