Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shorten_subject #503

Merged
merged 9 commits into from Jun 8, 2013
Merged

Replace shorten_subject #503

merged 9 commits into from Jun 8, 2013

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jun 7, 2013

PBE added a shorten_text function, this PR combines the two and updates the calls.

@eurich requested this a bit ago, I think this is what was needed. We can add additional "smarts" to shorten_text if wanted.

@Spuds
! remove shorten_subject and use the more general shorten_text in its…
9c679f1 
… place.

! Minor changes to shorten_text to make it backward compatable with shorten_subject

Signed-off-by: Spuds <spuds@spudsdesign.com>
@eurich
Copy link
Member

eurich commented Jun 8, 2013

👍 yeah, totally forgot my old PR.. was outdated and deleted, anyway..
would be nice if you could add a feature:

shorten_text($row['subject'], $modSettings['subject_length']),

IIRC I added four hidden settings in my old PR.
$modSettings['subject_length']
$modSettings['ssi_subject_length']
$modSettings['ssi_body_length'](for the preview one line below shorten_text%28%29)

I don't remember the fourth, but it was a hardcoded param related the shortened preview on board index or MessageIndex..

@Spuds
Copy link
Contributor Author

Spuds commented Jun 8, 2013

Makes sense to be a bit less hard coded ... so generally update them like:
shorten_text($row['subject'], !empty($modSettings['subject_length']) ? $modSettings['subject_length'] : 24);

Spuds added 5 commits June 8, 2013 08:46
@Spuds
! add $modSettings 'subject_length' and 'draft_subject_length'
844454c 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! missed that one call, it should be done as cutword
b901daf 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! add ssi_subject length
c7557f7 
! move preview to use the shorten_text function

Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! Update the message previews to use shorten_text
bae5684 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! can't use concatenation like that :)
6dc5ccb 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@eurich
Copy link
Member

eurich commented Jun 8, 2013

yep, and better worked out than my original PR 👍

Spuds added 3 commits June 8, 2013 15:57
@Spuds
! move a few more areas to use shorten_text
34ba1a8 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! Update maillist digest to use hidden setting, may expose this one s…
5694608 
…ince there is an ACP for it

Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
! missing global
2ad6f33 
Signed-off-by: Spuds <spuds@spudsdesign.com>
@Spuds
Copy link
Contributor Author

Spuds commented Jun 8, 2013

Think I got them all ... also found a few other areas where it could use the new / old function so changed them over as well.

norv added a commit that referenced this pull request Jun 8, 2013
@norv
Merge pull request #503 from Spuds/shorten
204ed81 
Replace shorten_subject
@norv norv merged commit 204ed81 into elkarte:master Jun 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Spuds @eurich @norv