fixed bug in Mojolicious::Renderer that prevented proxy objects from …

…being reused (closes #677)
mojolicious · Sep 22, 2014 · db01d44 · db01d44
1 parent 4bcf375
commit db01d44
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,7 @@
 
-5.44  2014-09-23
+5.44  2014-09-22
+  - Fixed bug in Mojolicious::Renderer that prevented proxy objects from being
+    reused.
 
 5.43  2014-09-22
   - Updated Makefile.PL for version 2 of the CPAN distribution metadata

diff --git a/lib/Mojolicious/Renderer.pm b/lib/Mojolicious/Renderer.pm
@@ -77,7 +77,7 @@ sub get_helper {
   }
 
   $found ? push @{$self->{namespaces}}, $class : return undef;
-  return $self->{proxy}{$name} = sub { bless \shift, $class };
+  return $self->{proxy}{$name} = sub { bless \(my $dummy = shift), $class };
 }
 
 sub render {

diff --git a/t/mojolicious/renderer.t b/t/mojolicious/renderer.t
@@ -91,6 +91,11 @@ is $second->helpers->myapp->defaults('foo'), 'nothing', 'right result';
 is $first->myapp->defaults('foo'), 'bar', 'right result';
 is $first->helpers->myapp->defaults('foo'), 'bar', 'right result';
 
+# Reuse proxy objects
+my $helpers = $first->helpers;
+is $helpers->myapp->multi_level->test, 'works!', 'right result';
+is $helpers->myapp->multi_level->test, 'works!', 'right result';
+
 # Missing method (AUTOLOAD)
 my $class = ref $first->myapp;
 eval { $first->myapp->missing };