Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_composite_mode on DBus-Api #161

Merged
merged 2 commits into from Jan 17, 2015

Conversation

MaZderMind
Copy link

Remote-Applications such as the Python-UI can retrieve the current Composition-Mode this way

Remote-Applications such as the Python-UI can retrieve the current Composition-Mode this way
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.26% when pulling b915863 on MaZderMind:get_composite_mode into a96b423 on timvideos:master.

@mithro
Copy link
Member

mithro commented Jan 17, 2015

Tests?

@MaZderMind
Copy link
Author

I'm unsure where the names you mentioned (I got the mail but can't find the message on github) should come into play. I copied most of the code from set_composite_mode and found the names in master not being used there either.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.15% when pulling fde91af on MaZderMind:get_composite_mode into a96b423 on timvideos:master.

mithro added a commit that referenced this pull request Jan 17, 2015
Implement get_composite_mode in API.
@mithro mithro merged commit a6d31c0 into timvideos:master Jan 17, 2015
@mithro
Copy link
Member

mithro commented Jan 17, 2015

Sorry that was my fault - shouldn't do code reviews when it's 2am :)

Those names are used in the controller.py not the connection.py file.

On 18 January 2015 at 03:12, Peter notifications@github.com wrote:

I'm unsure where the names you mentioned (I got the mail but can't find
the message on github) should come into play. I copied most of the code
from set_composite_mode and found the names in master not being used there
either.


Reply to this email directly or view it on GitHub
#161 (comment).

@MaZderMind MaZderMind deleted the get_composite_mode branch January 18, 2015 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants