Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 540ae4714fb5
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: dd66cd8cdcb9
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 18, 2013

  1. Revert "filter_api: ensure that the free_text where clauses are alway…

    …s ANDed"
    
    This reverts commit 543ba01.
    dregad committed Mar 18, 2013
    Copy the full SHA
    ce96109 View commit details
    Browse the repository at this point in the history
  2. Fix filter api issue with 'any condition' and text search

    A filter combining some criteria and a text search with 'any condition'
    results in a cartesian product, which has the potential to bring down
    the site as the RDBMS eats up all available resources.
    
    The root cause of this behavior is joining the bug_text table with a
    from clause and setting the join's criteria in the query's where clause,
    without taking consideration the operator's precedence (AND/OR).
    
    This commit resolves the problem by using a JOIN clause instead, which
    makes the query cleaner.
    
    Fixes #15573
    dregad committed Mar 18, 2013
    Copy the full SHA
    44055f8 View commit details
    Browse the repository at this point in the history
  3. Filter api: systematic use JOIN when building SQL

    Do not join tables using the where clause, for better readability and
    avoiding risk of issues with operator precedence and 'any condition'
    filtering mode.
    
    This commit also removes an unnecessary LEFT JOIN between the bugnote
    and bugnote_text tables; since this is a strict 1:1 relationship, an
    inner join is sufficient and yields better performance.
    dregad committed Mar 18, 2013
    Copy the full SHA
    dd66cd8 View commit details
    Browse the repository at this point in the history