When a module activator's started() method throws an exception, the

module should stop - TRUNK-3738
openmrs · Mar 8, 2013 · 58ac620 · 58ac620
1 parent 5410b7e
commit 58ac620
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/api/src/main/java/org/openmrs/module/ModuleUtil.java b/api/src/main/java/org/openmrs/module/ModuleUtil.java
@@ -807,12 +807,18 @@ public static AbstractRefreshableApplicationContext refreshApplicationContext(Ab
 
 					if (module.getModuleActivator() != null) {
 						module.getModuleActivator().contextRefreshed();
-						//if it is system start up, call the started method for all started modules
-						if (isOpenmrsStartup)
-							module.getModuleActivator().started();
-						//if refreshing the context after a user started or uploaded a new module
-						else if (!isOpenmrsStartup && module.equals(startedModule))
-							module.getModuleActivator().started();
+						try {
+							//if it is system start up, call the started method for all started modules
+							if (isOpenmrsStartup)
+								module.getModuleActivator().started();
+							//if refreshing the context after a user started or uploaded a new module
+							else if (!isOpenmrsStartup && module.equals(startedModule))
+								module.getModuleActivator().started();
+						}
+						catch (Exception e) {
+							log.warn("Unable to invoke started() method on the module's activator", e);
+							ModuleFactory.stopModule(module);
+						}
 					}
 
 				}