Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ca4da39
Choose a base ref
...
head repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 277681c
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 5, 2011

  1. Correct tag retrieval on SQL Server when no tags are defined 

    Fix #13363 : Application Failure when trying to select an issue
    @rombert
    rombert committed Oct 5, 2011

    Verified

    This commit was signed with the committer’s verified signature.
    nabijaczleweli наб
    GPG key ID: BCFD0B018D2658F1
    Verified
    Learn about vigilant mode
    Copy the full SHA
    47a2de4 View commit details

  2. Fix #13370 : CSV export specifies incorrect MIME type 

    Conflicts:
	csv_export.php
    @rombert
    rombert committed Oct 5, 2011

    Verified

    This commit was signed with the committer’s verified signature.
    nabijaczleweli наб
    GPG key ID: BCFD0B018D2658F1
    Verified
    Learn about vigilant mode
    Copy the full SHA
    277681c View commit details
Showing with 6 additions and 1 deletion.
  1. +5 −0 core/tag_api.php
  2. +1 −1 csv_export.php
5 changes: 5 additions & 0 deletions core/tag_api.php
View file
Original file line number Diff line number Diff line change
@@ -439,6 +439,11 @@ function tag_get_candidates_for_bug( $p_bug_id ) {
while( $row = db_fetch_array( $result ) ) {
$t_subquery_results[] = (int)$row;
}

if ( count ( $t_subquery_results ) == 0 ) {
return array();
}

$query = "SELECT id, name, description FROM $t_tag_table WHERE id IN ( " . implode( ', ', $t_subquery_results ) . ')';
} else {
$query = "SELECT id, name, description FROM $t_tag_table WHERE id IN (
2 changes: 1 addition & 1 deletion csv_export.php
View file
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@
# Make sure that IE can download the attachments under https.
header( 'Pragma: public' );

header( 'Content-Type: text/plain; name=' . urlencode( file_clean_name( $t_filename ) ) );
header( 'Content-Type: text/csv; name=' . urlencode( file_clean_name( $t_filename ) ) );
header( 'Content-Transfer-Encoding: BASE64;' );

# Added Quotes (") around file name.