csv-export plugin: improved field lookups #852
Conversation
zacronos
commented
Nov 27, 2013
zacronos
commented
- I changed csv-export to obey the displayName property from columnDefs, if present
- I changed csv-export to use UtilityService.evalProperty for field lookups (before calling the columnOverride function, if present). This is necessary to be consistent with ng-grid. For example, ng-grid allows field keys like "someObject.property" or even "someObject.array[0]"; if csv-export doesn't do the same thing, then csv-export can only work when all field keys are simple property names.
…ad of simple property lookup
|
This PR only talks about modifying csv-export but also has changes that affect the flexible-height plugin, navigation, etc. Can't merge without it being cleaned up. |
|
@c0bra: the only changes in this PR are to ng-grid-csv-export.js -- how does this affect the flexible-height plugin, navigation, etc? |
|
@c0bra: That's an illusion. That extra commit was an attempt at bringing this branch up to date with what was (at the time) the current HEAD of ng-grid. I must have done it in a way that wasn't as clean as it could have been -- I've never gotten the hang of squashing commits and rebasing. But, you can look at https://github.com/angular-ui/ng-grid/pull/852/files to see that the changes you are concerned about don't show up. The only changes you'll be introducing by accepting this pull request are the +9/-7 in zacronos@2e67090; everything in a21d19c is already in ng-grid |
