Remove const_missing compiler option

adambeynon · adambeynon · commit ceee79739365 · 2014-06-17T15:02:24.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@
 
 *   Cleanup generated code for constant access. All constant lookups now go through `$scope.get('CONST_NAME')` to produce cleaner code and a unified place for const missing dispatch.
 
+*   Remove `const_missing` option from compiler. All constant lookups are now strict.
+
 ## 0.6.2 2014-04-25
 
 *   Added Range#size
diff --git a/lib/opal/cli.rb b/lib/opal/cli.rb
@@ -126,7 +126,6 @@ def processor_option_names
       %w[
         method_missing_enabled
         arity_check_enabled
-        const_missing_enabled
         dynamic_require_severity
         source_map_enabled
         irb_enabled
diff --git a/lib/opal/cli_options.rb b/lib/opal/cli_options.rb
@@ -103,10 +103,6 @@ def initialize
         options[:arity_check] = true
       end
 
-      on('-C', '--no-const-missing', 'Enable/Disable const missing') do
-        options[:const_missing] = false
-      end
-
       dynamic_require_levels = %w[error warning ignore]
       on('-D', '--dynamic-require LEVEL', dynamic_require_levels,
                     'Set level of dynamic require severity.',
diff --git a/lib/opal/compiler.rb b/lib/opal/compiler.rb
@@ -36,9 +36,6 @@ def self.compiler_option(name, default_value, options = {})
     # adds an arity check to every method definition
     compiler_option :arity_check, false, :as => :arity_check?
 
-    # checks every constant access, delagating to const_missing if needed
-    compiler_option :const_missing, false, :as => :const_missing?
-
     # compile top level local vars with support for irb style vars
     compiler_option :irb, false, :as => :irb?
 
diff --git a/lib/opal/nodes/constants.rb b/lib/opal/nodes/constants.rb
@@ -10,10 +10,8 @@ class ConstNode < Base
       def compile
         if name == :DATA and compiler.eof_content
           push("$__END__")
-        elsif compiler.const_missing?
-          push "$scope.get('#{name}')"
         else
-          push "$scope.#{name}"
+          push "$scope.get('#{name}')"
         end
       end
     end
@@ -49,14 +47,9 @@ class ConstGetNode < Base
       children :base, :name
 
       def compile
-        if compiler.const_missing?
-          push "(("
-          push expr(base)
-          push ")._scope.get('#{name}'))"
-        else
-          push expr(base)
-          wrap '(', ")._scope.#{name}"
-        end
+        push "(("
+        push expr(base)
+        push ")._scope.get('#{name}'))"
       end
     end
 
diff --git a/spec/cli/compiler_spec.rb b/spec/cli/compiler_spec.rb
@@ -40,8 +40,8 @@
   end
 
   it "should compile constant lookups" do
-    expect_compiled("Object").to include("scope.Object")
-    expect_compiled("Array").to include("scope.Array")
+    expect_compiled("Object").to include("Object")
+    expect_compiled("Array").to include("Array")
   end
 
   describe "class names" do
