This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dns.lookup uses cares_wrap::GetAddrInfo
- Loading branch information
Showing
3 changed files
with
48 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 comments
on commit c83dda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ry - This commit breaks test/simple/test-dgram-pingpong.js
in my environment (Ubuntu).
...
client got: PONG from 127.0.0.1:20990
client has closed, closing server
dgram.js:179
var req = self._handle.send(buffer, offset, length, port, ip);
^
TypeError: Cannot call method 'send' of null
at dgram.js:179:30
at asyncCallback (dns.js:84:16)
at Object.onanswer [as oncomplete] (dns.js:135:9)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ry - Confirmed, test-dgram-pingpong
has succeeded.
But test-http-dns-fail
failed.
~/git/joyent/node$ ./node test/simple/test-http-dns-fail
getaddrinfo ENOENT
node.js:202
throw e; // process.nextTick error, or 'error' event on first tick
^
AssertionError: "EBADNAME" === "ENOTFOUND"
at ClientRequest.<anonymous> (/home/koichik/git/joyent/node/test/simple/test-http-dns-fail.js:48:12)
at ClientRequest.emit (events.js:67:17)
at Socket.<anonymous> (http.js:1106:11)
at Socket.emit (events.js:67:17)
at Array.<anonymous> (net.js:518:16)
at EventEmitter._tickCallback (node.js:194:26)
'ENOTFOUND'
?