Detect unregistered namespace prefixes and provide useful error messages... #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2014 20:45
| if (e instanceof QueryParseException) { | ||
| return new QueryParseExceptionMapper().toResponse((QueryParseException) e); | ||
| } | ||
|
|
||
| if ( e.getCause() instanceof RepositoryException) { |
There was a problem hiding this comment.
This isn't a comment on @whikloj 's work as much as a general comment: this class stinks. When I wrote it, it was really simple and just caught exceptions for which no other more appropriate mapper existed. Now it's full of brittle type testing. I'll open an issue.
- Removed from WildcardExceptionMapper - Added Provider annotation to QueryParseExceptionMapper Resolves: https://www.pivotaltracker.com/story/show/61500542
|
Resolved with: be7d793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in the UI.